fix(core): initialize route to avoid race (500) #13924
Merged
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
cherry-pick kong-ee
StarlightIbuki
force-pushed
the
fix/500-init-route
branch
2 times, most recently
from
103adf1
to
7eeb746
Compare
StarlightIbuki
force-pushed
the
fix/500-init-route
branch
from
7eeb746
to
a074c91
Compare
Oyami-Srk
approved these changes
Nov 26, 2024
Co-authored-by: Haoxuan <[email protected]>
ADD-SP
approved these changes
Nov 27, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13924-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13924-to-master-to-upstream
git checkout -b cherry-pick-13924-to-master-to-upstream
ancref=$(git merge-base 6fdad2580ef0c76a8920a4eded178339befcdc55 94fdea32cf73a4044cb51d3185aca02a028c1adf)
git cherry-pick -x $ancref..94fdea32cf73a4044cb51d3185aca02a028c1adf |
github-actions
bot
added
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The init router creation could be interrupted and we assume it will always be a non-nil value after the
init_workerphase, which may cause 500 to proxy requests.Let's create an empty router before creating the initial router.
As the issue occurs at this version I omitted the changelog.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5815